Open
Conversation
CodelineAtyab
requested changes
Aug 8, 2024
Owner
CodelineAtyab
left a comment
CodelineAtyab
left a comment
There was a problem hiding this comment.
Please respond to comments
Owner
There was a problem hiding this comment.
Since this is an IDE related config file, It should not be pushed because every user might have their own config file, and if they pull the changes, this file will conflict with theirs.
| environment: # Set environment variables for the Spring Boot application | ||
| SPRING_DATASOURCE_URL: jdbc:mysql://mysql:3307/usersystem?useSSL=false&serverTimezone=UTC&createDatabaseIfNotExist=true&allowPublicKeyRetrieval=true # JDBC URL for the MySQL database | ||
| SPRING_DATASOURCE_USERNAME: root | ||
| SPRING_DATASOURCE_PASSWORD: root |
Owner
There was a problem hiding this comment.
We should never push the password on GitHub.
Using the .env file can help solve this issues.
Owner
There was a problem hiding this comment.
Target directory is machine specific and should not be pushed with the project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have containerized the Spring Boot MVC application along with a MySQL database using Docker and Docker Compose. The Dockerfile builds the Spring Boot application, and the docker-compose.yml file orchestrates the application and database containers.
I have gone with using Maven and OpenJDK 17 from Docker itself instead of installing them.